Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, feat, docs: improve sax parser entity handling #3265

Merged
merged 14 commits into from
Jul 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: skip SAX external entities test in older libxml2
Before GNOME/libxml2@eddfbc38 the `#characters` event was duplicated
in this test case. I'm not going to work around it in Nokogiri.
  • Loading branch information
flavorjones committed Jul 2, 2024
commit ca5480e794b46554a55e4db2fd988841f635f1d2
2 changes: 2 additions & 0 deletions test/xml/sax/test_parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,8 @@ class TestCase
end

it "resolves local external entities when replace_entities is true" do
skip if Nokogiri.uses_libxml?("< 2.9.11") # gnome/libxml2@eddfbc38

Tempfile.create do |io|
io.write("local-contents")
io.close
Expand Down