Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upstream] html5lib-tests head has failing tests #2841

Closed
flavorjones opened this issue Apr 3, 2023 · 2 comments
Closed

[upstream] html5lib-tests head has failing tests #2841

flavorjones opened this issue Apr 3, 2023 · 2 comments
Labels
topic/gumbo Gumbo HTML5 parser

Comments

@flavorjones
Copy link
Member

Updates to upstream https://github.com/html5lib/html5lib-tests are failing in Nokogiri's "upstream" CI:

These failures are from one of these two commits:

Here's the output for the seven failing tests:

Failure:
TestHtml5TreeConstructionWebkit02#test_11 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <b><em><dcell><postfield><postfield><postfield><postfield><missing_glyph><missing_glyph><missing_glyph><missing_glyph><hkern><aside></b></em>.
Expected: 0
  Actual: 3

Failure:
TestHtml5TreeConstructionWebkit02#test_11__with_node [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <b><em><dcell><postfield><postfield><postfield><postfield><missing_glyph><missing_glyph><missing_glyph><missing_glyph><hkern><aside></b></em>.
Expected: 0
  Actual: 3

Failure:
TestHtml5TreeConstructionWebkit01#test_26 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <html><body></body>
   <!-- Hi there --></html>.
Expected: 0
  Actual: 1

Failure:
TestHtml5TreeConstructionWebkit01#test_27 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <html><body></body></html>
   <!-- Hi there -->.
Expected: 0
  Actual: 1

Failure:
TestHtml5TreeConstructionTemplate#test_107 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <body></body><template>.
Expected: 0
  Actual: 3

Failure:
TestHtml5TreeConstructionTemplate#test_106 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:120]
Minitest::Assertion: Wrong number of errors for <html><head></head><template></template><head>.
Expected: 0
  Actual: 3

Failure:
TestHtml5TreeConstructionTemplate#test_110 [/__w/nokogiri/nokogiri/test/html5/test_tree_construction.rb:24]
Minitest::Assertion: Expected: "template"
  Actual: "html"
@flavorjones flavorjones added the topic/gumbo Gumbo HTML5 parser label Apr 3, 2023
@liyang1473

This comment was marked as off-topic.

Sign in to view
@flavorjones
Copy link
Member Author

Upstream PR: html5lib/html5lib-tests#165

Nokogiri PR: #2842

Presumptively closing this issue.

@flavorjones flavorjones mentioned this issue Apr 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/gumbo Gumbo HTML5 parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavorjones @liyang1473