Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in file NokogiriHelpers.java? #1516

Closed
AppChecker opened this issue Jul 25, 2016 · 0 comments
Closed

Bug in file NokogiriHelpers.java? #1516

AppChecker opened this issue Jul 25, 2016 · 0 comments

Comments

@AppChecker
Copy link

Hi!

Please, look the code of function nodesAreEqual (NokogiriHelpers.java, line 551):

   return (((a == null) && (a == null)) ||
                (a != null) && (b != null) &&
                (b.equals(a)));

(a == null) is checked twice.
May be it should be:

   return (((a == null) && (b == null)) ||
                (a != null) && (b != null) &&
                (b.equals(a)));

This possible defect found by AppChecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants