Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with LED pin definitions #8

Open
DeadlyJesus opened this issue Sep 27, 2021 · 0 comments
Open

Issue with LED pin definitions #8

DeadlyJesus opened this issue Sep 27, 2021 · 0 comments

Comments

@DeadlyJesus
Copy link

DeadlyJesus commented Sep 27, 2021

Hi,
This might be a misunderstanding on my part but, on the board definition for the nRF SDK (sparkfun_nrf52840_mini.h), two leds are declared, yet only one is actually connected on the board.

define LED_1          NRF_GPIO_PIN_MAP(0,7)

This is the definition for the blue user led connected to P0.07 (23)

#define LED_2          NRF_GPIO_PIN_MAP(0,14)

This definition is for a led that should be connected to P0.14 (36) yet the schematic show that this pin isn't connected to anything

Also, the definitions for BSP_LED_[...] uses pin 7 twice:

#define BSP_LED_0      7
#define BSP_LED_1      7

Shouldn't there be only one LED or am I missing something ?
I think it should be changed to:

#define LEDS_NUMBER    1

#define LED_1          NRF_GPIO_PIN_MAP(0,7)
#define LED_START      LED_1
#define LED_STOP       LED_1

#define LEDS_ACTIVE_STATE 1

#define LEDS_LIST { LED_1 }

#define LEDS_INV_MASK  LEDS_MASK

#define BSP_LED_0      7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant