Skip to content

fixing printChar() so that shift functions can move characters printed by printChar #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cchuneke
Copy link

added a line that assigns the input of printChar() to the local RAM, to allow shiftLeft() and shiftRight() to work on characters printed with printChar().

@sfe-SparkFro
Copy link
Contributor

Thanks for this!

I created #27 to track this, as it looks like there's other places where displayContent needs to be corrected, such as in clear(). If you'd like to fix those as well, that would be great! Otherwise we will try to get around to it when we can.

@cchuneke
Copy link
Author

cchuneke commented Jul 1, 2025

Sure! I missed #27 when looking at the issues somehow, and I'm also surprised I didn't find any of the other problems while I was working with the library. I'll see what I can and can't fix myself.

@sfe-SparkFro
Copy link
Contributor

I missed #27 when looking at the issues somehow

I created it after you created this PR, just so we can track it properly 🙂

I'll see what I can and can't fix myself

Thanks!

@cchuneke
Copy link
Author

cchuneke commented Jul 2, 2025

I don't actually have one of the displays to test things on myself (only have one at work since I used it for a work project), but I think this will fix the issue with clear(). There is another loop in size_t HT16K33::write(const uint8_t *buffer, size_t size) that clears displayRAM the same way clear() does, but given the rest of the function I'm not sure that displayContent needs to be cleared there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants