New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP caching issues while using the subfolder.conf file #17

Open

paolomainardi opened this issue Apr 3, 2019 · 1 comment

Member

paolomainardi commented Apr 3, 2019

When using this image with the subfolder.conf configuration file, we basically miss all the needed caching headers on the static assets, we should backport this configuration: https://github.com/sparkfabrik/docker-php-drupal-nginx/blob/feature/d8/1.13.6-alpine/templates/default.conf#L100

To avoid problems like this one:

 ❯ curl -I https://www.example.com/de/de/themes/custom/example_corporate/images/logo.svg                                                     ✭
HTTP/2 200
server: nginx
date: Wed, 03 Apr 2019 11:05:09 GMT
content-type: image/svg+xml
content-length: 4621
last-modified: Wed, 03 Apr 2019 09:06:15 GMT
vary: Accept-Encoding
etag: "5ca47787-120d"
accept-ranges: bytes
via: 1.1 google
alt-svc: clear

The text was updated successfully, but these errors were encountered:

Member Author

paolomainardi commented Apr 3, 2019

cc @marcogiacomassi @Pinolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment