feat: zero rate deposit failure tests

Author: deluca-mike

test/base-fork/Morpho.t.sol

@@ -181,6 +181,17 @@ contract MorphoDepositFailureTests is MorphoBaseTest {
         foreignController.depositERC4626(MORPHO_VAULT_USDS, 25_000_000e18);
     }
 
+    function test_morpho_usdc_deposit_zeroExchangeRate() external {
+        deal(Base.USDS, address(almProxy), 25_000_000e18);
+
+        vm.prank(Base.SPARK_EXECUTOR);
+        foreignController.setMaxExchangeRate(MORPHO_VAULT_USDS, 0, 0);
+
+        vm.prank(relayer);
+        vm.expectRevert("FC/exchange-rate-too-high");
+        foreignController.depositERC4626(MORPHO_VAULT_USDS, 1e18);
+    }
+
 }
 
 contract MorphoDepositSuccessTests is MorphoBaseTest {

test/mainnet-fork/4626Calls.t.sol

@@ -106,6 +106,18 @@ contract MainnetControllerDepositERC4626FailureTests is SUSDSTestBase {
         mainnetController.depositERC4626(address(susds), 5_000_000e18);
     }
 
+    function test_depositERC4626_zeroExchangeRate() external {
+        vm.prank(relayer);
+        mainnetController.mintUSDS(5_000_000e18);
+
+        vm.prank(Ethereum.SPARK_PROXY);
+        mainnetController.setMaxExchangeRate(address(susds), 0, 0);
+
+        vm.prank(relayer);
+        vm.expectRevert("MC/exchange-rate-too-high");
+        mainnetController.depositERC4626(address(susds), 5_000_000e18);
+    }
+
 }
 
 contract MainnetControllerDepositERC4626Tests is SUSDSTestBase {

test/mainnet-fork/ERC4626DonationAttack.t.sol

@@ -86,7 +86,7 @@ contract ERC4626DonationAttack is ERC4626DonationAttackTestBase {
 
     function test_depositERC4626_donationAttackFailure() external {
         vm.startPrank(Ethereum.SPARK_PROXY);
-        mainnetController.setMaxExchangeRate(address(morphoVault), morphoVault.convertToShares(1e18), 1.2e18);
+        mainnetController.setMaxExchangeRate(address(morphoVault), 1e18, 10e18);
         vm.stopPrank();
 
         _doAttack();

test/mainnet-fork/Maple.t.sol

@@ -145,6 +145,17 @@ contract MainnetControllerDepositERC4626MapleFailureTests is MapleTestBase {
         mainnetController.depositERC4626(address(syrup), 1_000_000e6);
     }
 
+    function test_depositERC4626_maple_zeroExchangeRate() external {
+        deal(address(usdc), address(almProxy), 1_000_000e6);
+
+        vm.prank(Ethereum.SPARK_PROXY);
+        mainnetController.setMaxExchangeRate(address(syrup), 0, 0);
+
+        vm.prank(relayer);
+        vm.expectRevert("MC/exchange-rate-too-high");
+        mainnetController.depositERC4626(address(syrup), 1_000_000e6);
+    }
+
 }
 
 contract MainnetControllerDepositERC4626Tests is MapleTestBase {