Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign_wcs should be able to evaluate the WCS with non-coordinate inputs #3908

Open
stscijgbot opened this issue Aug 12, 2019 · 0 comments
Open

Comments

@stscijgbot
Copy link
Collaborator

Issue JP-930 was created by Nadia Dencheva:

It will be useful to have a way to pass non-coordinate inputs to the WCS object and evaluate the transforms using those inputs. For example, the Nirspec WCS pipeline now is a compound object which includes the transforms for all slits/shutters/slices. Evaluating it is a two step process:

 
{code:java}
im = ImageModel(input_file)
slit_A200_1_wcs = nirspec.nrs_wcs_set_input(im, 'S200A1')
ra, dec, lam = slit_A200_1_wcs(x, y)
{code}
Instead it will be much more convenient to do

 
{code:java}
im = ImageModel(input_file)
ra, dec, lam = im.meta.wcs(x, y, slit_name='S200A1')
{code}
This requires changes in gwcs and  astropy.modeling. In GWCS the work is tracked in [spacetelescope/gwcs#152|https://github.com/spacetelescope/gwcs/issues/152]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants