Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible MIRI/MRS world 2 detector bug. #1406

Open
baileyji opened this issue Nov 1, 2017 · 3 comments
Open

Possible MIRI/MRS world 2 detector bug. #1406

baileyji opened this issue Nov 1, 2017 · 3 comments

Comments

@baileyji
Copy link

baileyji commented Nov 1, 2017

Hi Folks,
I'm seeing very unexpected behavior in the world to detector transform as captured in this gist (note you will need to contact me for the supporting fits files).

The short of it is that computing a set of x,y pixel coordinates from a mesh of ra, dec, and lambda yields regions on the detector that are outside (If I'm using the code properly) of the slices on on the detector.

screen shot 2017-11-01 at 6 01 51 pm

https://gist.github.com/baileyji/1a1c4762bbc303f9f0a3a10503a5da64

@nden
Copy link
Collaborator

nden commented Nov 6, 2017

After offline discussions, I think there's no bug. The reason for seeing values between slices is that the regions mask is not applied to output values of the inverse transform. I'm closing this but two new issues cam out of the discussions - #1427 and #1428

@nden
Copy link
Collaborator

nden commented Dec 7, 2017

After much back and forth I think I understand the issue now.
When going from alpha, beta to detector, the beta value alone is used to determine which slice the (alpha, beta) value belongs to. Instead, it is necessary to also look at the range of alpha values for each slice.
Here's an example for a 12SHORT exposure:

alpha, beta = ( 3.19529725, 2.0776295)

Based on beta only this point belongs to slice 216. However, the alpha range for slice 216 is
(-2.17462231, 2.13811708). Based on the alpha value this point should have a value of NaN on the detector, while now it goes through the "alpha_beta to detector" transform and has a real value on the detector. Looking at the pixel location on the detector and using the forward transform, it actually belongs to slice 207 (another indication it's wrong).

@hbushouse hbushouse added this to the Build 7.2 milestone Feb 13, 2018
@nden nden modified the milestones: Build 7.2, Build 7.3 Sep 11, 2018
@stscicrawford stscicrawford modified the milestones: Build 7.3, Build 7.4 Sep 20, 2019
@stscicrawford stscicrawford modified the milestones: Build 7.4, Build 7.5 Dec 4, 2019
@hbushouse hbushouse modified the milestones: Build 7.5, Build 7.9 Jun 22, 2021
@hbushouse
Copy link
Collaborator

Can this be retested to see if it's still a problem in B7.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants