Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file naming in outlier_detection #1223

Open
jdavies-st opened this issue Sep 20, 2017 · 0 comments
Open

Fix file naming in outlier_detection #1223

jdavies-st opened this issue Sep 20, 2017 · 0 comments
Assignees
Milestone

Comments

@jdavies-st
Copy link
Collaborator

Currently in outlier_detection, the writing out of intermediate files is handled by subroutines or subroutines of subroutines. Ideally, this should happen in the OutlierDetectionStep.process method at the top level and be done using the standard Step.save_model methods.

This will require a significant refactor of where most of the logic of the step happens. Currently it happens in the OutlierDetection class, but it really should be happening in the OutlierDetectionStep class.

@jdavies-st jdavies-st added this to the Build 7.2 milestone Sep 20, 2017
@jdavies-st jdavies-st self-assigned this Sep 20, 2017
@stscicrawford stscicrawford modified the milestones: Build 7.2, Build 7.3 Sep 7, 2018
@stscicrawford stscicrawford modified the milestones: Build 7.3, Build 7.4 Jun 7, 2019
@stscicrawford stscicrawford modified the milestones: Build 7.4, Future Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants