Skip to content

Commit

Permalink
[fix](action) Update pr-approve-status.yml (apache#26577)
Browse files Browse the repository at this point in the history
According to https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#list-reviews-for-a-pull-request,
the number of results per page default is 30 (max 100).
review of  APPROVED after 30 will not be listed,
change to 100 to fix it.
  • Loading branch information
hello-stephen authored Nov 10, 2023
1 parent 2712bb9 commit 0e0cd3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pr-approve-status.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
echo "PR number is not set"
exit 1
fi
response=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }} " "https://api.github.com/repos/apache/doris/pulls/${pr_num}/reviews")
response=$(curl -s -H "Authorization: token ${{ secrets.GITHUB_TOKEN }} " "https://api.github.com/repos/apache/doris/pulls/${pr_num}/reviews?per_page=100")
# shellcheck disable=SC2207
reviewers=($(echo $response | jq -r '.[] | .user.login'))
# shellcheck disable=SC2207
Expand Down

0 comments on commit 0e0cd3b

Please sign in to comment.