Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tickets #7

Open
sweetgiorni opened this issue Feb 22, 2021 · 1 comment
Open

Create Tickets #7

sweetgiorni opened this issue Feb 22, 2021 · 1 comment

Comments

@sweetgiorni
Copy link
Contributor

Could you create some tickets for work that needs to be done? I see you've completed a good chunk of the IR implementation and I didn't want to jump into something that will be deprecated.

Some things I suspect should be done, but I'm not sure:

  • Refactor test directory (Perhaps a dedicated folder for each test case because of all the generated files?)\
  • Fix broken tests
  • Remove old HLSLDecompiler from tests
  • Port code generation logic from OldHLSLDecompiler to use the new IR classes
@spacehamster
Copy link
Owner

I've opened some issues
#8
#9

Refactor test directory (Perhaps a dedicated folder for each test case because of all the generated files?)\

i'm open to suggestions.

Fix broken tests

Ideally the important tests would be the recompile test that ensures that would recompiling the HLSL output matches the original bytecode input, but this is a long way off (and may not interact well with optimisations). The other tests are mainly just sanity tests that are difficult to get 100% right at this stage.

Remove old HLSLDecompiler from tests

This should already be the case.

Port code generation logic from OldHLSLDecompiler to use the new IR classes

This is difficult to do until #8 is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants