Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Add support for phi-3 mini model #209

Closed
1 task done
surenderssm opened this issue Apr 23, 2024 · 3 comments
Closed
1 task done

[REQ] Add support for phi-3 mini model #209

surenderssm opened this issue Apr 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@surenderssm
Copy link

What kind of request is this?

New feature

What is your request or suggestion?

I would like to add a support for phi-3 mini model.

https://huggingface.co/microsoft/Phi-3-mini-128k-instruct

I am very new to this ecosystem, however I have a strong desire to learn and contribute in this space, pointers or references will be enough for me to get started. Let me know your thoughts!

Are you willing to submit PRs to contribute to this feature request?

  • Yes, I am willing to implement it.
@surenderssm surenderssm added the enhancement New feature or request label Apr 23, 2024
@sozercan
Copy link
Owner

sozercan commented Apr 23, 2024

@surenderssm thanks for opening an issue! I just added the phi 3 3.7b model. see https://sozercan.github.io/aikit/premade-models

this is not the 128k version but the 4k one. if you are interested in contributing, it'll be similar to #210 but for 128k gguf file. I didn't see the gguf for the 128k one at the time

@sozercan
Copy link
Owner

sozercan commented Apr 23, 2024

Looks like llama.cpp doesn't support 128k yet due to longrope scaling type: ggerganov/llama.cpp#6849

@sozercan
Copy link
Owner

sozercan commented Jun 3, 2024

Looks like ggerganov/llama.cpp#7225 added support for 128k version. aikit v0.9.0 includes the llama.cpp version that has this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants