Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timespan struct #1

Open
soypat opened this issue Mar 24, 2021 · 1 comment
Open

Timespan struct #1

soypat opened this issue Mar 24, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@soypat
Copy link
Owner

soypat commented Mar 24, 2021

Since it's inception, the Timespan struct has been a patch to a bigger problem in godesim. There really is not much control over the domain in which the equations are integrated. Steps are a fixed size unless using an adaptive timestep method, and even then the method will choose the domain division. One can get around this by using events, which is OK for the most part, except for all the extra code.

Timespan really does not do much, it just suggests a timestep and a end time. If there is a more elegant solution, and there most certainly is, the difficulty would probably be adapting present day godesim's Timespan API usage to a new API.

The name is also a source of bother to me, I wish I had named it Domain, since there is no reason godesim only solves time-domain problems.

@soypat soypat added the enhancement New feature or request label Jun 4, 2021
@soypat
Copy link
Owner Author

soypat commented Sep 8, 2021

This will be addressed when gonum develops the ode package. Algorithm logic will be replaced by gonum's logic which would probably be better supported than what is seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant