Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated PR: Cookstyle Changes #606

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Automated PR: Cookstyle Changes #606

merged 1 commit into from
Apr 15, 2020

Conversation

xorimabot
Copy link
Contributor

Hey!
I ran Cookstyle 6.2.9 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/alternatives.rb

  • 49:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
  • 62:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
  • 75:11 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal

Issues found and resolved with resources/jce.rb

  • 51:6 refactor: ChefStyle/UnnecessaryOSCheck - Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.

Issues found and resolved with: resources/alternatives.rb

 - 49:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
 - 62:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
 - 75:11 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal

Issues found and resolved with: resources/jce.rb

 - 51:6 refactor: ChefStyle/UnnecessaryOSCheck - Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.

Signed-off-by: Xorima Bot <xorimabot@avon-lea.co.uk>
@xorimabot xorimabot requested a review from a team April 14, 2020 19:05
@kitchen-porter
Copy link
Contributor

1 Warning
⚠️ This Pull Request is probably missing tests.

Generated by 🚫 Danger

@xorima xorima merged commit f3606ca into master Apr 15, 2020
@github-actions github-actions bot deleted the automated/cookstyle branch April 15, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants