Automated PR: Cookstyle Changes #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues found and resolved with: resources/alternatives.rb - 49:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal - 62:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal - 75:11 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal Issues found and resolved with: resources/jce.rb - 51:6 refactor: ChefStyle/UnnecessaryOSCheck - Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values. Signed-off-by: Xorima Bot <xorimabot@avon-lea.co.uk>
Generated by 🚫 Danger |
xorima
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I ran Cookstyle 6.2.9 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook
Changes
Issues found and resolved with resources/alternatives.rb
ChefCorrectness/ChefApplicationFatal- Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatalChefCorrectness/ChefApplicationFatal- Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatalChefCorrectness/ChefApplicationFatal- Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatalIssues found and resolved with resources/jce.rb
ChefStyle/UnnecessaryOSCheck- Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.