Feature/bitset vocabulary optimization #549
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looking interesting! Once CI passes, we will send the benchmark results. Right now they are failing on formatting. Make sure to run "make" on your machine to re-format the code automatically using ClangFormat |
syedazeez337
force-pushed
the
feature/bitset-vocabulary-optimization
branch
6 times, most recently
from
b9d603a to
b730b7f
Compare
Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
syedazeez337
force-pushed
the
feature/bitset-vocabulary-optimization
branch
from
b730b7f to
2c5d61c
Compare
Member
|
Oh the repo benchmarks don't run on forks... I forgot we hit an upstream issue with this: https://github.com/sourcemeta/blaze/blob/main/.github/workflows/ci.yml#L145-L147. Can you post the before/after (i.e. with and without this commit) for |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hash-based std::unordered_map vocabulary storage with bitset flags for O(1) lookups, reducing compilation time from 4618ms to 2195ms (-52%) and vocabulary lookup CPU overhead from 31.3% to 6.5%
(-79%). Includes comprehensive testing across 40+ real-world schemas and full test suite validation with zero regressions.