Skip to content

correct headers for exporting usage data to file #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasonhawkharris merged 2 commits into from
May 31, 2023
Merged

correct headers for exporting usage data to file #987

jasonhawkharris merged 2 commits into from
May 31, 2023

Conversation

@jasonhawkharris
Copy link
Contributor

@jasonhawkharris jasonhawkharris commented May 26, 2023

Test plan

Manual testing

  • exported data for resources (k8s, docker) and usage (k8s, docker). Correct output returned

jdpleiness
jdpleiness approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonhawkharris jasonhawkharris merged commit 7fc6627 into main May 31, 2023
@jasonhawkharris jasonhawkharris deleted the jhh/fix-export-headers branch May 31, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdpleiness jdpleiness jdpleiness approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonhawkharris @jdpleiness