Chore: Rename 'primary' to 'pgsql' in the src-cli commands for database uploads #1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pgsql/frontenddatabase already has too much confusion over its name when TS teams work with self-hosted customer admins. As far as I'm aware, thesrc snapshot databasescommands for taking and uploading database snapshots as part of the migration from self-hosted to our Cloud is the only place our customers see the same database get a bonus third nameprimary, adding unnecessary confusion to a process which is already a little overwhelming for our customers, specifically the types of customers we're encouraging to migrate from self-hosted to Cloud.I propose renaming
primary->pgsqlin these src-cli commands, because that's the name of the pod / container which our self-hosted customer admins and TS teams already work with on a day-to-day basis, and it matches the database's name in the SG Cloud infra, and the rest of the commands throughout the migration process:Customer commands:
IE commands:
This database is referred to as
frontendin database schema code, however, our self-hosted customer admins are never exposed to the database namefrontend; it is the pgsql container that they work with / are taking the snapshot out of. The database name inside the container is alsosg, but renaming the src-cli commands tosgwouldn't be any clearer.Test plan
Naming change