codeintel: Fail fast on 401 failure in SCIP detection (#1034)

varungandhi-src · web-flow · commit 573ddf8c7a56 · 2023-09-03T19:34:37.000-05:00
Don't convert SCIP to LSIF, don't attempt to upload the index
diff --git a/cmd/src/code_intel_upload_flags.go b/cmd/src/code_intel_upload_flags.go
@@ -202,6 +202,9 @@ func isSCIPAvailable() (bool, error) {
 		return false, err
 	}
 	defer resp.Body.Close()
+	if resp.StatusCode == http.StatusUnauthorized {
+		return false, upload.ErrUnauthorized
+	}
 
 	return resp.StatusCode == http.StatusOK, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,9 @@ func isSCIPAvailable() (bool, error) {`
`202`	`202`	`return false, err`
`203`	`203`	`}`
`204`	`204`	`defer resp.Body.Close()`
	`205`	`+ if resp.StatusCode == http.StatusUnauthorized {`
	`206`	`+ return false, upload.ErrUnauthorized`
	`207`	`+ }`
`205`	`208`
`206`	`209`	`return resp.StatusCode == http.StatusOK, nil`
`207`	`210`	`}`