This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Use lsp-client #36
Open
Use lsp-client #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
reviewed
Mar 5, 2019
18 tasks
chrismwendt
commented
May 29, 2019
| })(ctx) | ||
| } | ||
|
|
||
| async function activatePreciseUsingLspClient(ctx: sourcegraph.ExtensionContext): Promise<void> { |
There was a problem hiding this comment.
This function activatePreciseUsingLspClient is really the only new piece in this PR. The other changes were due to restructuring the code.
chrismwendt
commented
May 29, 2019
| doc, | ||
| pos, | ||
| sendRequest: ({ rootURI, requestType, request, useCache }) => | ||
| client.withConnection(rootURI, conn => conn.sendRequest(requestType, request)), |
There was a problem hiding this comment.
This is the part that gets into an infinite loop without sourcegraph/lsp-client#42
61 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature-flags
@sourcegraph/lsp-clientbased on thelspclientglobal/org/user setting:{ // ... "lspclient": true, // ... }You have to be running
sourcegraph/lang-go:insiders@sha256:9b2eb14e6acdd41c3e7fe312b79a72200efa4cac096eb13e2ecd86ee67821a62(or newer) because lsp-client is not compatible with older versions of go-langserver.This depends on a solution to sourcegraph/lsp-client#41 (e.g. sourcegraph/lsp-client#42).
Resolves #28