Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sourcegraph/jetbrains
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.0.13
Choose a base ref
...
head repository: sourcegraph/jetbrains
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.18
Choose a head ref
  • 15 commits
  • 40 files changed
  • 5 contributors

Commits on Oct 15, 2024

  1. Fix repo url parsing (#2442)

    Fixes https://linear.app/sourcegraph/issue/CODY-3132
    
    ## Changes
    
    1. `extensionConfiguration_didChange` is not called anymore on every
    opening of the file. It was used to set `cody.codebase` settings key on
    the Cody side. But it should not be needed, as[ it should always be
    obtained from the currently opened
    file](https://github.com/sourcegraph/cody/blob/main/vscode/src/repository/git-metadata-for-editor.ts#L53)
    anyway.
    
    ## Test plan
    
    1. Create git test project 
    2. Edit `.git/config` file and change `[remote "origin"]` to contain url
    like:
    `url = git@github.com:122345/a/b/c/my-Repo.git`
    3. Run IntelliJ and switch files few times - there should be no errors
    (in fact that code path is not executed anymore)
    4. Click right mouse button, `Sourcegraph` > `Open Selection In
    Sourcegraph Web`
    5. It should fail, but URL should start with
    `https://sourcegraph.com/github.com/1234/sourcegraph/a/b/my-Repo/@main/-/blob/`
    pkukielka authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4776bcd View commit details
    Browse the repository at this point in the history
  2. Improve autocomplete UX (#2439)

    Related to https://github.com/sourcegraph/cody/pull/5871.
    
    In this PR we make use of the recent changes ☝️ we remove some redundant
    calculations for completion text.
    Additionally, we properly derive the insertion text and the position for
    the inlay. That makes the inlays look more fancy and precise.
    
    Note that Remote Dev does not use inlays. Some completions won't look
    that nice there yet (but it is no worse).
    
    ## Demo 
    
    ### Before  
    
    https://github.com/user-attachments/assets/805c9012-7393-45fd-8d9f-22ae4cd5bf30
    
    ### After
    
    https://github.com/user-attachments/assets/d5c2e7b6-4bc9-4ee5-ab8c-4f9c427915aa
    
    ## Test plan
    
    Autocomplete works in all cases
    
    | | remote dev | regular |
    | --- | --- | --- |
    | single line | Case 1 | Case 2 | 
    |  multi line | Case 3 | Case 4 |
    mkondratek authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    318b5aa View commit details
    Browse the repository at this point in the history
  3. Fix verification plugin issues related to InlineCompletionProviderID (#…

    …2450)
    
    ## Changes
    
    1. Fixed `InlineCompletionProviderID` package
    2. Added a few comments
    
    ## Test plan
    
    N/A, it is related to the test/verification infrastructure.
    It should decrease amount of compatibility issues reported by
    verification job on the marketplace.
    pkukielka authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f1722cd View commit details
    Browse the repository at this point in the history
  4. Update README.md (#2435)

    Updates the JetBrains marketplace page.
    - Changes "Commands" to "Prompts"
    - QOL updates to sync against the VSC marketplace
    
    ## Test plan
    
    Marketing copy update only.
    Alex Isken authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2090ae8 View commit details
    Browse the repository at this point in the history
  5. feat(uninstall): delete auth credentials on uninstall (CODY-1043) (#2434

    )
    
    This is the JetBrains half of the
    [CODY-1043](https://linear.app/sourcegraph/issue/CODY-1043/bug-account-credentials-are-cached-between-installs),
    the VSC half of it is in [this
    PR](https://github.com/sourcegraph/cody/pull/5819).
    
    For VSCode I was able to write an E2E as there are electron & VSCode
    test utilities for opening / closing instances of VSC and installing /
    uninstalling plugins.
    
    Does anyone know if we have similar utilities that we could use to write
    a test for this behavior in JB?
    
    The good news is that JB actually has proper APIs for this hook so the
    complexity is much lower here.
    
    ## Test plan
    I manually tested this by running `CODY_DIR='<my local cody>' ./gradlew
    -PforceAgentBuild=true buildPlugin` and then opening the plugins menu
    and installing a plugin from disk.
    
    ![image](https://github.com/user-attachments/assets/0b0c7482-9dce-4ce5-8f80-07b60857e1d9)
    
    I logged in and then uninstalled from the same menu. After reinstalling,
    it takes me back to the login screen and all previous endpoints are
    cleared. When I log back into the same account I see my chat history is
    removed.
    jamesmcnamara authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    65f65c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Remove redundant duration formatter (#2463)

    The code was used in the chat in the deprecated UI. We do not need it
    anymore.
    
    ## Test plan
    1. N/A
    mkondratek authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7822694 View commit details
    Browse the repository at this point in the history
  2. Fix error in navigation from context files (#2464)

    Fixes
    https://linear.app/sourcegraph/issue/QA-122/jetbrains-crash-occurred-while-clicking-on-file-name-from-chat-context.
    
    ## Test plan
    1. Follow the repro steps from the QA report - that is, run Explain Code
    and try the context files navigation links
    mkondratek authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a09e299 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Handle runtime missing JCEF (#2451)

    Resolves
    https://linear.app/sourcegraph/issue/CODY-3753/make-it-possible-to-automatically-switch-user-runtime-to-one-which.
    
    ## Test plan 
    
    ### Dev run (`:customRunIde`)
    1. Modify `build.gradle.kts`. Change
      ```
    dependencies {
      intellijPlatform {
        jetbrainsRuntime()
    ...
      ```
      to
      ```
    dependencies {
      intellijPlatform {
        jetbrainsRuntimeExplicit("jbr-21.0.3-osx-aarch64-b446.1")
    ...
      ```
    so that the IDE will use no jcef runtime at the start. 
    2. `:customRunIde`
    3. Verify the notification appears
    4. Verify the proper panel appears
    mkondratek authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    78605bc View commit details
    Browse the repository at this point in the history
  2. add repo/jetbrains label to bug reports (#2472)

    Adding `repo/jetbrains` label to help distinguish where the issue came
    from when we sync it back to linear. Will also do the same to the Cody
    repo so that we have one single point of entry for all bugs
    
    ## Test plan
    N/A
    
    <!-- All pull requests REQUIRE a test plan:
    https://sourcegraph.com/docs/dev/background-information/testing_principles
    
    Why does it matter?
    
    These test plans are there to demonstrate that are following industry
    standards which are important or critical for our customers.
    They might be read by customers or an auditor. There are meant be simple
    and easy to read. Simply explain what you did to ensure
    your changes are correct!
    
    Here are a non exhaustive list of test plan examples to help you:
    
    - Making changes on a given feature or component:
    - "Covered by existing tests" or "CI" for the shortest possible plan if
    there is zero ambiguity
      - "Added new tests"
    - "Manually tested" (if non trivial, share some output, logs, or
    screenshot)
    - Updating docs:
      - "previewed locally"
      - share a screenshot if you want to be thorough
    - Updating deps, that would typically fail immediately in CI if
    incorrect
      - "CI"
      - "locally tested"
    -->
    kalanchan authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    12c7254 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Bump Cody commit (#2478)

    ## Test plan
    
    Full QA is needed.
    pkukielka authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    437e3e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Revert "feat(uninstall): delete auth credentials on uninstall (CODY-1043

    ) (#2434)" (#2484)
    
    This reverts commit 65f65c5.
    
    The UninstallListener introduced in this commit seems to run for every
    extension uninstall instead of just when the sourcegraph extension is
    uninstalled.
    
    ## Test plan
    This will need to be manually tested.
    jamesmcnamara authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    96ea1c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Bump Cody commit (#2499)

    ## Test plan
    
    Full QA
    pkukielka authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    510e082 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Fix project build with platformVersion >= 2024 (#2492)

    ## Changes
    
    1. Fixed package for `InlineCompletionSuggestion`
    2. Added separate versions of `CodyInlineCompletionProvider` for IJ 2023
    and 2024 (although 2024 version will be used only if `platformVersion`
    is changed explicitly, e.g. using `-PplatformVersion=2024.2`).
    3. Fixed build definition issues for IJ 2024, mostly connected with
    missing VCS packages.
    
    ## Test plan
    
    Verify that completions and opening Revision Diff in Sourcegraph Web
    works:
    
    * In IntelliJ 2023.2
    * In IntelliJ 2024.2
    * In IntelliJ 2024.2 in split mode (or using remote directly)
    pkukielka authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e74204f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fix loading of CodyInlineCompletionProvider in IJ 2023 (#2510)

    ## Changes
    
    Fixes BUGS-577 
    
    In IJ 2023 we want `CodyInlineCompletionProvider` to be disabled, but we
    need to load the class to make the check.
    `InlineCompletionProviderID` class does not exist in 2023.2 and younger,
    so loading class was failing.
    
    ## Test plan
    
    1. Open IJ 2023.2 and check if autocomplete works. No exception should
    be thrown.
    2. Open IJ 2024.2 in remote mode and check if autocomplete works. No
    exception should be thrown.
    pkukielka authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    02f7f40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc369a8 View commit details
    Browse the repository at this point in the history
Loading