Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sourcegraph/jetbrains
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.0.0
Choose a base ref
...
head repository: sourcegraph/jetbrains
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.1
Choose a head ref
  • 6 commits
  • 18 files changed
  • 4 contributors

Commits on Sep 3, 2024

  1. fix/Windows: Open Cody Settings Editor should not pass file paths as …

    …URIs (#2202)
    
    Fixes #2201
    
    ## Test plan
    
    Manually tested:
    
    1. Open the Cody sidebar.
    2. ... , Open Cody Settings Editor
    
    Verify this opens a file with some curly braces instead of throwing an
    exception.
    Dominic Cooney authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    be20eb5 View commit details
    Browse the repository at this point in the history
  2. Fix offset conversions at the end of the document (#2203)

    Fixes #2196
    
    ## Changes
    
    Conversion of the end of range to offset was buggy.
    VSC sometimes sends `-1` as line index. If the start or end position of
    the range is outside the document, the corresponding offset should be
    set to 0 or the document's text length, respectively.
    But in case of the end range we were setting it to `0`.
    
    To avoid that mistake:
    * I changed `Position::toOffset` method name to
    `Position::toOffsetOrZero` to be very explicit of what it does. It
    should not be used for ranges, but sometimes we only have a single
    position (like for a text insert).
    * I added `Range::toOffsetRange` which returns pair of offsets,
    correcting them appropriately depending if position is a start or end
    
    ## Test plan
    
    1. Login to Cody with Free/Pro user
    2. Create new empty python file called quicksort.py, make sure it's
    empty
    3. Ask Cody to "create a quicksort function"
    4. Click on Apply, make sure code is added to source code file
    5. Click on Reject
    
    Edit should be properly rejected and file should be empty again.
    pkukielka authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fde7f3c View commit details
    Browse the repository at this point in the history
  3. Fix windows build (#2206)

    ## Changes
    
    Finally fixes windows gradle/pnpm build.
    
    Couple of additional deps I had to install manually (but it could be due
    to my `node` version or some other setup detail):
    `npx install gulp`
    `npx install gulp-cli`
    `npx install cross-env`
    `npx update-browserlist-db@latest` // possibly not needed
    
    Also, windows comandline can be more picky, e.g.
    `.\gradlew :runIDE -PplatformRuntimeVersion='2024.1.2'`
    (notice '' around a version)
    
    ## Test plan
    
    N/A
    pkukielka authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0ae7e48 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix shortcuts for Edit Code on Windows (#2223)

    ## Changes
    
    Removes annoying `Alt + Enter` shortcut and unifies both bringing `Edit
    Code` prompt and confirming an edit into a single shortcut.
    
    ## Test plan
    
    1. Select some code in the editor
    2. Hit `Ctrl Enter` to show `Edit Code` prompt
    3. Add some instruction, e.g. to add comments
    4. Hit `Ctrl Enter` again to confirm the changes and do an edit
    pkukielka authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    78b09c1 View commit details
    Browse the repository at this point in the history
  2. Register widgets for disposal (#2225)

    ## Test plan
    1. n/a
    mkondratek authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1406a49 View commit details
    Browse the repository at this point in the history
  3. Update cody commit (#2226)

    Includes a fix for #2197
    
    ## Test plan
    1. full qa
    
    ---------
    
    Co-authored-by: Piotr Kukielka <pkukielka@virtuslab.com>
    mkondratek and pkukielka authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    813d3f5 View commit details
    Browse the repository at this point in the history
Loading