Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Match SymbolDescriptors with a numeric score #249

Merged
merged 7 commits into from
May 15, 2017
Merged

Conversation

felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented May 12, 2017

This allows a workspace/symbol with SymbolDescriptor query to still match a symbol where e.g. all properties expect the containerName match as long as there is no better match.
workspace/symbol now streams results in the order of the match score (through the JSON Patch path index).

@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

Merging #249 into master will decrease coverage by 0.03%.
The diff coverage is 75.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   57.86%   57.83%   -0.04%     
==========================================
  Files          13       13              
  Lines        2053     2056       +3     
  Branches      338      340       +2     
==========================================
+ Hits         1188     1189       +1     
  Misses        731      731              
- Partials      134      136       +2
Impacted Files Coverage Δ
src/util.ts 74.82% <66.66%> (-0.37%) ⬇️
src/typescript-service.ts 69.35% <76.74%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168c60f...3f0e0e8. Read the comment docs.

@felixfbecker felixfbecker merged commit 61edbfa into master May 15, 2017
@felixfbecker felixfbecker deleted the symbol-match-score branch May 15, 2017 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants