This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Derive zip URL from template #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
approved these changes
May 10, 2019
chrismwendt
force-pushed
the
derive-zip-url-from-template
branch
from
bf479c5 to
2602558
Compare
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing both
zipURLandzipURLTemplateis redundant.zipURLcan be derived by instantiating thezipURLTemplatewithoriginalRootURI.This adds support for clients that omit
zipURLand only providezipURLTemplate. This is part of simplifying lsp-client's communication with go-langserver.