Skip to content

Updating dead link #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Updating dead link #39

merged 1 commit into from
Jul 7, 2023

Conversation

alexAtSourcegraph
Copy link
Contributor

Description

A dead link for the Enterprise Guide was updated.

Checklist

Test plan

Verified manually.

@alexAtSourcegraph alexAtSourcegraph enabled auto-merge (squash) July 7, 2023 19:15
Copy link

@jasonhawkharris jasonhawkharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexAtSourcegraph alexAtSourcegraph merged commit 355dee3 into main Jul 7, 2023
DaedalusG added a commit that referenced this pull request Jun 24, 2025
…ate main target bug (#287)

Closes REL-1069

## Problem

The release pipeline has been systematically failing in the
`promoteToPublic.finalize` workflow with this error:
```
Warning: 1 uncommitted change
must be on a branch named differently than 'promote/release-v6.4.3889-update-main'
```

## Root Cause

The final `github:pr` step in the `promoteToPublic.finalize` workflow
was incorrectly trying to create a PR from the current branch to itself:

- **Current branch**: `promote/release-{{version}}-update-main`
- **Target branch**: `promote/release-{{version}}-update-main` ❌ (same
branch!)
- **Should target**: `main` ✅

This happened because the variable `internal_branch` was set to the
current branch name instead of the intended target branch.

### Test plan
This will have to be tested on a release <br> Backport
61f4376 from #286

Co-authored-by: Warren Gifford <warrenbruceg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants