Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, it is useful to provide transformations that are run before submission verification. For example, it is possible that submissions have a legitimate use for
System.exit
, which should not disqualify the submission from being graded.While submissions with illegal instructions (such as
System.exit
) should be eliminated by the end of the compilation/transformation phase, it should be possible to transform these illegal instructions to prevent submissions that would otherwise be thrown out, to be graded.This PR adds a new enum
ClassTransformerOrder
and a new overload toRubricConfiguration
, namelyaddTransformer(ClassTransformer, ClassTransformerOrder). Currently, the two values for the order are
DEFAULTand
PRE` (more may be added later).Transformers registered under
PRE
will be run before submission verification, and all transformers registered underDEFAULT
will run after all of Jagr's own transformers.The scope of this PR is mostly a minor change (addition) with only a usually unused method being incompatibly changed.
Breaking API change:
RubricConfiguration.getTransformers
returnsMap<ClassTransformerOrder, List<ClassTransformer>>
instead ofList<ClassTransformer>
.