Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework grading result minPoints and maxPoints #40

Merged
merged 18 commits into from
Dec 14, 2021
Merged

Rework grading result minPoints and maxPoints #40

merged 18 commits into from
Dec 14, 2021

Conversation

alexstaeding
Copy link
Member

@alexstaeding alexstaeding commented Dec 14, 2021 •
edited
Loading

Migrate GradingResult to use similar semantics to minPoints and maxPoints from Gradable.

This PR adds a new common interface PointRange with the properties minPoints and maxPoints.

Supersedes #38.

@alexstaeding alexstaeding mentioned this pull request Dec 14, 2021
Closed
@alexstaeding alexstaeding added the semver:major A major change breaking backwards compatibility label Dec 14, 2021
@alexstaeding alexstaeding added this to the v0.3 milestone Dec 14, 2021
@alexstaeding alexstaeding merged commit de3b9c8 into master Dec 14, 2021
@alexstaeding alexstaeding deleted the feature/0.3/grading-result-rework branch December 14, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:major A major change breaking backwards compatibility
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@alexstaeding