Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RubricForSubmission and TestForSubmission deprecations from v0.6 #149

Merged
merged 1 commit into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,10 @@ class GraderJarImpl(
rubricProvider.configure(configuration)
}

@Suppress("DEPRECATION")
private fun MutableList<String>.addIfTest(clazz: Class<*>) {
val annotation = clazz.getAnnotation(TestForSubmission::class.java) ?: return
add(clazz.name)
if (annotation.value.isNotBlank() && annotation.value != clazz.name) {
logger.warn(
"Grader ${info.name} test class ${clazz.name} " +
"has a non-blank value ${annotation.value} in @TestForSubmission and it does not match " +
"the grader's assignmentId ${info.assignmentId}"
)
logger.warn("Providing a value to @TestForSubmission is deprecated and will be removed in a future version")
}
logger.debug("Grader ${info.name} discovered test provider ${clazz.name} for assignment ${annotation.value}")
logger.debug("Grader ${info.name} discovered test provider ${clazz.name} for assignment ${info.assignmentId}")
}

override fun toString(): String = info.name
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@

/**
* Used to provide a {@link Rubric} for a submission.
*
* <p>
* Implementation must be annotated with {@link RubricForSubmission} in order to be discovered.
* </p>
*/
public interface RubricProvider {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,4 @@
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
public @interface TestForSubmission {

/**
* The assignment id of the submission.
*
* @return The assignment id of the submission
* @deprecated No longer read by Jagr, the assignmentId is provided via the generated grader-info.json
*/
@Deprecated(forRemoval = true)
String value() default "";
}