Skip to content

Commit add3469

Browse files
committed
ux: always show Merge (Built-in) context menu entry for conflicts
Signed-off-by: leo <longshuang@msn.cn>
1 parent 89675c3 commit add3469

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

src/Views/WorkingCopy.axaml.cs

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -338,21 +338,16 @@ private ContextMenu CreateContextMenuForUnstagedChanges(ViewModels.WorkingCopy v
338338

339339
if (change.ConflictReason is Models.ConflictReason.BothAdded or Models.ConflictReason.BothModified)
340340
{
341-
var isBinary = new Commands.IsBinary(repo.FullPath, "HEAD", change.Path).GetResultAsync().GetAwaiter().GetResult();
342-
if (!isBinary)
341+
var mergeBuiltin = new MenuItem();
342+
mergeBuiltin.Header = App.Text("ChangeCM.Merge");
343+
mergeBuiltin.Icon = App.CreateMenuIcon("Icons.Conflict");
344+
mergeBuiltin.Click += async (_, e) =>
343345
{
344-
var mergeBuiltin = new MenuItem();
345-
mergeBuiltin.Header = App.Text("ChangeCM.Merge");
346-
mergeBuiltin.Icon = App.CreateMenuIcon("Icons.Conflict");
347-
mergeBuiltin.Click += async (_, e) =>
348-
{
349-
var ctx = new ViewModels.MergeConflictEditor(repo, change.Path);
350-
await ctx.LoadAsync();
351-
await App.ShowDialog(ctx);
352-
e.Handled = true;
353-
};
354-
menu.Items.Add(mergeBuiltin);
355-
}
346+
var ctx = new ViewModels.MergeConflictEditor(repo, change.Path);
347+
await ctx.LoadAsync();
348+
await App.ShowDialog(ctx);
349+
e.Handled = true;
350+
};
356351

357352
var mergeExternal = new MenuItem();
358353
mergeExternal.Header = App.Text("ChangeCM.MergeExternal");
@@ -362,6 +357,8 @@ private ContextMenu CreateContextMenuForUnstagedChanges(ViewModels.WorkingCopy v
362357
await vm.UseExternalMergeToolAsync(change);
363358
e.Handled = true;
364359
};
360+
361+
menu.Items.Add(mergeBuiltin);
365362
menu.Items.Add(mergeExternal);
366363
}
367364

0 commit comments

Comments
 (0)