Skip to content

Adds code navigation and highlighting support for Tcl #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2025
Merged

Conversation

msukkari
Copy link
Contributor

@msukkari msukkari commented Jun 21, 2025

Uses our new Tcl code mirror extension: https://github.com/sourcebot-dev/codemirror-lang-tcl

image

Summary by CodeRabbit

  • New Features

    • Enhanced support for Tcl syntax highlighting and hover interactions using updated language support.
    • Added recognition of additional Tcl syntax elements for symbol hover decorations.
  • Chores

    • Updated dependencies to use the latest Tcl language package for improved compatibility and features.

@msukkari msukkari requested a review from brendan-kellam June 21, 2025 03:16
Copy link

coderabbitai bot commented Jun 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new CodeMirror 6 Tcl language package was added as a dependency. The Tcl language integration in the code editor was updated to use this new package, replacing the legacy mode. Additionally, symbol hover functionality was extended to recognize more Tcl-specific syntax node types for hover decorations.

Changes

File(s) Change Summary
packages/web/package.json Added @sourcebot/codemirror-lang-tcl as a dependency.
packages/web/src/lib/codemirrorLanguage.ts Switched Tcl language support from legacy CodeMirror 5 mode to CodeMirror 6 package in the language map.
packages/web/src/ee/features/codeNav/components/symbolHoverPopup/symbolHoverTargetsExtension.ts Extended recognized node types for symbol hover decorations to include Tcl-specific types.
CHANGELOG.md Added changelog entry for Tcl language support addition under "Unreleased" section.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CodeEditor
    participant TclLangSupport

    User->>CodeEditor: Opens/edit Tcl file
    CodeEditor->>TclLangSupport: Load CodeMirror 6 Tcl language support
    CodeEditor->>User: Display Tcl code with syntax highlighting

    User->>CodeEditor: Hover over Tcl symbol
    CodeEditor->>CodeEditor: Recognize Tcl node type (ProcName, ProcInvocation, etc.)
    CodeEditor->>User: Show hover decoration for Tcl symbol
Loading

Possibly related PRs

Poem

In the warren of code, a new friend appears,
Tcl hops forward, shedding old-mode fears.
Symbols gleam brighter, with underlines anew,
CodeMirror 6 magic, in editor view.
With every new package, our garden expands—
Hooray for fresh syntax in bunny-coder hands! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4bbe62 and a4be9fa.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • packages/web/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

brendan-kellam
brendan-kellam previously approved these changes Jun 21, 2025
@msukkari msukkari merged commit 1c790ec into main Jun 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants