Skip to content

connections qol improvements #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/backend/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const DEFAULT_SETTINGS: Settings = {
autoDeleteStaleRepos: true,
reindexIntervalMs: 1000 * 60,
resyncConnectionPollingIntervalMs: 1000,
reindexRepoPollingInternvalMs: 1000,
reindexRepoPollingIntervalMs: 1000,
indexConcurrencyMultiple: 3,
configSyncConcurrencyMultiple: 3,
}
4 changes: 3 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const compileGithubConfig = async (
external_codeHostUrl: hostUrl,
cloneUrl: cloneUrl.toString(),
name: repoName,
imageUrl: repo.owner.avatar_url,
isFork: repo.fork,
isArchived: !!repo.archived,
org: {
Expand Down Expand Up @@ -80,6 +81,7 @@ export const compileGitlabConfig = async (
external_codeHostUrl: hostUrl,
cloneUrl: cloneUrl.toString(),
name: project.path_with_namespace,
imageUrl: project.avatar_url,
isFork: isFork,
isArchived: !!project.archived,
org: {
Expand Down Expand Up @@ -118,7 +120,6 @@ export const compileGiteaConfig = async (
const hostUrl = config.url ?? 'https://gitea.com';

return giteaRepos.map((repo) => {
const repoUrl = `${hostUrl}/${repo.full_name}`;
const cloneUrl = new URL(repo.clone_url!);

const record: RepoData = {
Expand All @@ -127,6 +128,7 @@ export const compileGiteaConfig = async (
external_codeHostUrl: hostUrl,
cloneUrl: cloneUrl.toString(),
name: repo.full_name!,
imageUrl: repo.owner?.avatar_url,
isFork: repo.fork!,
isArchived: !!repo.archived,
org: {
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/repoManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class RepoManager implements IRepoManager {
this.fetchAndScheduleRepoIndexing();
this.garbageCollectRepo();

await new Promise(resolve => setTimeout(resolve, this.settings.reindexRepoPollingInternvalMs));
await new Promise(resolve => setTimeout(resolve, this.settings.reindexRepoPollingIntervalMs));
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export type Settings = {
/**
* The polling rate (in milliseconds) at which the db should be checked for repos that should be re-indexed.
*/
reindexRepoPollingInternvalMs: number;
reindexRepoPollingIntervalMs: number;
/**
* The multiple of the number of CPUs to use for indexing.
*/
Expand Down
69 changes: 67 additions & 2 deletions packages/web/src/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { giteaSchema } from "@sourcebot/schemas/v3/gitea.schema";
import { gerritSchema } from "@sourcebot/schemas/v3/gerrit.schema";
import { ConnectionConfig } from "@sourcebot/schemas/v3/connection.type";
import { encrypt } from "@sourcebot/crypto"
import { getConnection } from "./data/connection";
import { ConnectionSyncStatus, Prisma, Invite, OrgRole } from "@sourcebot/db";
import { getConnection, getLinkedRepos } from "./data/connection";
import { ConnectionSyncStatus, Prisma, Invite, OrgRole, Connection, Repo, Org } from "@sourcebot/db";
import { headers } from "next/headers"
import { getStripe } from "@/lib/stripe"
import { getUser } from "@/data/user";
Expand Down Expand Up @@ -236,6 +236,41 @@ export const createConnection = async (name: string, type: string, connectionCon
}
}));

export const getConnectionInfoAction = async (connectionId: number, domain: string): Promise<{ connection: Connection, linkedRepos: Repo[] } | ServiceError> =>
withAuth((session) =>
withOrgMembership(session, domain, async (orgId) => {
const connection = await getConnection(connectionId, orgId);
if (!connection) {
return notFound();
}

const linkedRepos = await getLinkedRepos(connectionId, orgId);

return {
connection,
linkedRepos: linkedRepos.map((repo) => repo.repo),
}
})
);

export const getOrgFromDomainAction = async (domain: string): Promise<Org | ServiceError> =>
withAuth((session) =>
withOrgMembership(session, domain, async (orgId) => {
const org = await prisma.org.findUnique({
where: {
id: orgId,
},
});

if (!org) {
return notFound();
}

return org;
})
);


export const updateConnectionDisplayName = async (connectionId: number, name: string, domain: string): Promise<{ success: boolean } | ServiceError> =>
withAuth((session) =>
withOrgMembership(session, domain, async (orgId) => {
Expand Down Expand Up @@ -298,6 +333,36 @@ export const updateConnectionConfigAndScheduleSync = async (connectionId: number
}
}));

export const flagConnectionForSync = async (connectionId: number, domain: string): Promise<{ success: boolean } | ServiceError> =>
withAuth((session) =>
withOrgMembership(session, domain, async (orgId) => {
const connection = await getConnection(connectionId, orgId);
if (!connection || connection.orgId !== orgId) {
return notFound();
}

if (connection.syncStatus !== "FAILED") {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.CONNECTION_NOT_FAILED,
message: "Connection is not in a failed state. Cannot flag for sync.",
} satisfies ServiceError;
}

await prisma.connection.update({
where: {
id: connection.id,
},
data: {
syncStatus: "SYNC_NEEDED",
}
});

return {
success: true,
}
}));

export const deleteConnection = async (connectionId: number, domain: string): Promise<{ success: boolean } | ServiceError> =>
withAuth((session) =>
withOrgMembership(session, domain, async (orgId) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const RepoListItem = ({
case RepoIndexingStatus.NEW:
return 'Waiting...';
case RepoIndexingStatus.IN_INDEX_QUEUE:
return 'In index queue...';
case RepoIndexingStatus.INDEXING:
return 'Indexing...';
case RepoIndexingStatus.INDEXED:
Expand Down
158 changes: 116 additions & 42 deletions packages/web/src/app/[domain]/connections/[id]/page.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"use client";

import { NotFound } from "@/app/[domain]/components/notFound";
import {
Breadcrumb,
Expand All @@ -10,58 +12,108 @@ import {
import { ScrollArea } from "@/components/ui/scroll-area";
import { TabSwitcher } from "@/components/ui/tab-switcher";
import { Tabs, TabsContent } from "@/components/ui/tabs";
import { getConnection, getLinkedRepos } from "@/data/connection";
import { ConnectionIcon } from "../components/connectionIcon";
import { Header } from "../../components/header";
import { ConfigSetting } from "./components/configSetting";
import { DeleteConnectionSetting } from "./components/deleteConnectionSetting";
import { DisplayNameSetting } from "./components/displayNameSetting";
import { RepoListItem } from "./components/repoListItem";
import { getOrgFromDomain } from "@/data/org";
import { PageNotFound } from "../../components/pageNotFound";

interface ConnectionManagementPageProps {
params: {
id: string;
domain: string;
},
searchParams: {
tab?: string;
}
}
import { useParams, useSearchParams } from "next/navigation";
import { useEffect, useState } from "react";
import { Connection, Repo, Org } from "@sourcebot/db";
import { getConnectionInfoAction, getOrgFromDomainAction, flagConnectionForSync } from "@/actions";
import { isServiceError } from "@/lib/utils";
import { Button } from "@/components/ui/button";
import { ReloadIcon } from "@radix-ui/react-icons";
import { useToast } from "@/components/hooks/use-toast";

export default async function ConnectionManagementPage({
params,
searchParams,
}: ConnectionManagementPageProps) {
const org = await getOrgFromDomain(params.domain);
if (!org) {
return <PageNotFound />
}
export default function ConnectionManagementPage() {
const params = useParams();
const searchParams = useSearchParams();
const { toast } = useToast();
const [org, setOrg] = useState<Org | null>(null);
const [connection, setConnection] = useState<Connection | null>(null);
const [linkedRepos, setLinkedRepos] = useState<Repo[]>([]);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);

const connectionId = Number(params.id);
if (isNaN(connectionId)) {
return (
<NotFound
className="flex w-full h-full items-center justify-center"
message="Connection not found"
/>
)
useEffect(() => {
const loadData = async () => {
try {
const orgResult = await getOrgFromDomainAction(params.domain as string);
if (isServiceError(orgResult)) {
setError(orgResult.message);
setLoading(false);
return;
}
setOrg(orgResult);

const connectionId = Number(params.id);
if (isNaN(connectionId)) {
setError("Invalid connection ID");
setLoading(false);
return;
}

const connectionInfoResult = await getConnectionInfoAction(connectionId, params.domain as string);
if (isServiceError(connectionInfoResult)) {
setError(connectionInfoResult.message);
setLoading(false);
return;
}

connectionInfoResult.linkedRepos.sort((a, b) => {
// Helper function to get priority of indexing status
const getPriority = (status: string) => {
switch (status) {
case 'FAILED': return 0;
case 'IN_INDEX_QUEUE':
case 'INDEXING': return 1;
case 'INDEXED': return 2;
default: return 3;
}
};

const priorityA = getPriority(a.repoIndexingStatus);
const priorityB = getPriority(b.repoIndexingStatus);

// First sort by priority
if (priorityA !== priorityB) {
return priorityA - priorityB;
}

// If same priority, sort by createdAt
return new Date(a.createdAt).getTime() - new Date(b.createdAt).getTime();
});

setConnection(connectionInfoResult.connection);
setLinkedRepos(connectionInfoResult.linkedRepos);
setLoading(false);
} catch (err) {
setError(err instanceof Error ? err.message : "An error occurred while loading the connection. If the problem persists, please contact us at team@sourcebot.dev");
setLoading(false);
}
};

loadData();
const intervalId = setInterval(loadData, 1000);
return () => clearInterval(intervalId);
}, [params.domain, params.id]);

if (loading) {
return <div>Loading...</div>;
}

const connection = await getConnection(Number(params.id), org.id);
if (!connection) {
if (error || !org || !connection) {
return (
<NotFound
className="flex w-full h-full items-center justify-center"
message="Connection not found"
message={error || "Not found"}
/>
)
);
}

const linkedRepos = await getLinkedRepos(connectionId, org.id);

const currentTab = searchParams.tab || "overview";
const currentTab = searchParams.get("tab") || "overview";

return (
<Tabs
Expand Down Expand Up @@ -116,7 +168,30 @@ export default async function ConnectionManagementPage({
</div>
<div className="rounded-lg border border-border p-4 bg-background">
<h2 className="text-sm font-medium text-muted-foreground">Status</h2>
<p className="mt-2 text-sm">{connection.syncStatus}</p>
<div className="flex items-center gap-2">
<p className="mt-2 text-sm">{connection.syncStatus}</p>
{connection.syncStatus === "FAILED" && (
<Button
variant="outline"
size="sm"
className="mt-2 rounded-full"
onClick={async () => {
const result = await flagConnectionForSync(connection.id, params.domain as string);
if (isServiceError(result)) {
toast({
description: `❌ Failed to flag connection for sync. Reason: ${result.message}`,
})
} else {
toast({
description: "✅ Connection flagged for sync.",
})
}
}}
>
<ReloadIcon className="h-4 w-4" />
</Button>
)}
</div>
</div>
</div>
</div>
Expand All @@ -127,12 +202,12 @@ export default async function ConnectionManagementPage({
<div className="flex flex-col gap-4">
{linkedRepos
.sort((a, b) => {
const aIndexedAt = a.repo.indexedAt ?? new Date();
const bIndexedAt = b.repo.indexedAt ?? new Date();
const aIndexedAt = a.indexedAt ?? new Date();
const bIndexedAt = b.indexedAt ?? new Date();

return bIndexedAt.getTime() - aIndexedAt.getTime();
})
.map(({ repo }) => (
.map((repo) => (
<RepoListItem
key={repo.id}
imageUrl={repo.imageUrl ?? undefined}
Expand Down Expand Up @@ -162,6 +237,5 @@ export default async function ConnectionManagementPage({
/>
</TabsContent>
</Tabs>

)
);
}
Loading