more feedback

Author: brendan-kellam

package.json

@@ -16,7 +16,7 @@
         "dev:prisma:migrate:dev": "yarn with-env yarn workspace @sourcebot/db prisma:migrate:dev",
         "dev:prisma:studio": "yarn with-env yarn workspace @sourcebot/db prisma:studio",
         "dev:prisma:migrate:reset": "yarn with-env yarn workspace @sourcebot/db prisma:migrate:reset",
-        "build:deps": "yarn workspaces foreach -R --from '{@sourcebot/schemas,@sourcebot/error,@sourcebot/crypto,@sourcebot/db}' run build"
+        "build:deps": "yarn workspaces foreach -R --from '{@sourcebot/schemas,@sourcebot/error,@sourcebot/crypto,@sourcebot/db,@sourcebot/shared}' run build"
     },
     "devDependencies": {
         "cross-env": "^7.0.3",

packages/shared/README.md

@@ -0,0 +1,9 @@
+This package contains shared code between the backend & webapp packages.
+
+### Why two index files?
+
+This package contains two index files: `index.server.ts` and `index.client.ts`. There is some code in this package that will only work in a Node.JS runtime (e.g., because it depends on the `fs` pacakge. Entitlements are a good example of this), and other code that is runtime agnostic (e.g., `constants.ts`). To deal with this, we these two index files export server code and client code, respectively.
+
+For package consumers, the usage would look like the following:
+- Server: `import { ... } from @sourcebot/shared`
+- Client: `import { ... } from @sourcebot/shared/client`

packages/shared/src/env.ts

@@ -6,9 +6,21 @@ export const env = createEnv({
     server: {
         SOURCEBOT_EE_LICENSE_KEY: z.string().optional(),
         SOURCEBOT_PUBLIC_KEY_PATH: z.string(),
+    },
+    // @NOTE: Please make sure of the following:
+    // - Make sure you destructure all client variables in
+    //   the `runtimeEnv` block below.
+    // - Update the Dockerfile to pass these variables as build-args.
+    client: {
         NEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENT: z.enum(SOURCEBOT_CLOUD_ENVIRONMENT).optional(),
     },
-    runtimeEnv: process.env,
+    clientPrefix: "NEXT_PUBLIC_",
+    runtimeEnv: {
+        ...process.env,
+
+        // For Next.js >= 13.4.4, you need to manually destructure client variables:
+        NEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENT: process.env.NEXT_PUBLIC_SOURCEBOT_CLOUD_ENVIRONMENT,
+    },
     emptyStringAsUndefined: true,
     skipValidation: process.env.SKIP_ENV_VALIDATION === "1",
 });