Skip to content

Commit 2934fa3

Browse files
committed
Move linting step into the matrix
1 parent 54a5659 commit 2934fa3

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/workflows/pull-request.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ jobs:
134134
run: |
135135
cd ${{ matrix.tabInfo.directory }}
136136
yarn tsc
137-
137+
yarn lint
138+
138139
bundles:
139140
runs-on: ubuntu-latest
140141
needs: find-packages
@@ -174,6 +175,12 @@ jobs:
174175
cd ${{ matrix.bundleInfo.directory }}
175176
yarn test --coverage
176177
178+
- name: Run Linting
179+
if: matrix.bundleInfo.changes
180+
run: |
181+
cd ${{ matrix.bundleInfo.directory }}
182+
yarn lint
183+
177184
devserver:
178185
name: Dev Server Tasks
179186
runs-on: ubuntu-latest
@@ -258,9 +265,6 @@ jobs:
258265
- name: Lint Global
259266
run: yarn buildtools lintglobal
260267

261-
- name: Lint Bundles and Tabs
262-
run: yarn workspaces foreach -j 5 -pW --from "./src/{bundles,tabs}/*" run lint
263-
264268
- name: Build Manifest
265269
run: yarn buildtools manifest
266270

0 commit comments

Comments
 (0)