Grading: Viewable Assessment Briefings #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-frontend into grading-briefing
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…demy#2769) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Enable Stepper for Typed Variant * Fix format * Modify CI tests, enabling Stepper tool for Typed Variant --------- Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
…demy#2771) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Replace deprecated `ITreeNode` with `TreeNodeInfo` Done as per migration guide. * Upgrade BlueprintJS dependencies to v5 * Use public `IconName` type instead of internal API Fixes a compile error following the version upgrade. * Migrate to `Datetime2` package Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration. * Update prop name Fixes the breaking change introduced by the Blueprint v5 upgrade. * Update test snapshots * Reran `yarn install` post-merge * Update snapshots post-merge * Update SCSS namespace * Fix popover styles Update the target classes to match the new components. * Revert Env Vizualiser snapshot change * Fix TreeNode comparison to compare id instead of object reference --------- Co-authored-by: sayomaki <sayomayomaki@gmail.com>
…rceacademy-frontend into grading-briefing
Pull Request Test Coverage Report for Build 7984433971Details
💛 - Coveralls |
lhw-1
reviewed
Feb 18, 2024
There was a problem hiding this comment.
Thanks for the PR @InfinityTwo! The changes for the new query response format are pretty straightforward & we can maybe include an image for the PR, but otherwise, LGTM.
lhw-1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added a tab to view the briefings (long summary) inside the assessment for grading that resolves #2310
Note
gradingdue to a new query response format from the backend API.GradingAnswers(previously known asGrading) andGradingQuery, but I have tested it as much as possible.Type of change
How to test
Checklist