-
Notifications
You must be signed in to change notification settings - Fork 56
Enhancement: Include assessment with answers in submission #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Include assessment with answers in submission #1059
Conversation
GabrielCWT
commented
Feb 2, 2024
- Update get_answers_in_submission to query for the assessment for the submission
- Update admin_grading_controller to accept assessment and answers from SQL query
- Implement admin_grading_view assessment.json template
- Update admin_grading_view show.json template
a1b4268
to
f4fa55b
Compare
f4fa55b
to
61b175f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this! Just a minor comment below, but otherwise, LGTM! Though we need to wait for the other team to prepare the corresponding frontend PR before we can merge this….
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
6135f91
to
315d83a
Compare
* Added briefing (long summary) to Grading (#2310) * Updated grading briefing to be inline with backend's camelCase * resolve on some type conflicts * fix for TypeError on test action * Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup * resolved edited export type Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.
* Added briefing (long summary) to Grading (source-academy#2310) * Updated grading briefing to be inline with backend's camelCase * resolve on some type conflicts * fix for TypeError on test action * Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup * resolved edited export type Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.