Skip to content

Enhancement: Include assessment with answers in submission #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GabrielCWT
Copy link
Contributor

  • Update get_answers_in_submission to query for the assessment for the submission
  • Update admin_grading_controller to accept assessment and answers from SQL query
  • Implement admin_grading_view assessment.json template
  • Update admin_grading_view show.json template

@GabrielCWT GabrielCWT changed the title Enhancement: Include the Enhancement: Include assessment with answers in submission Feb 2, 2024
@coveralls
Copy link

coveralls commented Feb 2, 2024

Coverage Status

coverage: 95.277% (+0.02%) from 95.257%
when pulling 315d83a on GabrielCWT:enhancement/answers-and-assessment
into 426c3a9 on source-academy:master.

@GabrielCWT GabrielCWT force-pushed the enhancement/answers-and-assessment branch 2 times, most recently from a1b4268 to f4fa55b Compare February 2, 2024 15:48
@GabrielCWT GabrielCWT force-pushed the enhancement/answers-and-assessment branch from f4fa55b to 61b175f Compare February 2, 2024 15:55
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this! Just a minor comment below, but otherwise, LGTM! Though we need to wait for the other team to prepare the corresponding frontend PR before we can merge this….

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sayomaki sayomaki force-pushed the enhancement/answers-and-assessment branch from 6135f91 to 315d83a Compare February 21, 2024 06:05
lhw-1 pushed a commit to source-academy/frontend that referenced this pull request Feb 21, 2024
* Added briefing (long summary) to Grading (#2310)

* Updated grading briefing to be inline with backend's camelCase

* resolve on some type conflicts

* fix for TypeError on test action

* Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup

* resolved edited export type

Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.
@RichDom2185 RichDom2185 merged commit dd89ec9 into source-academy:master Feb 21, 2024
@GabrielCWT GabrielCWT deleted the enhancement/answers-and-assessment branch February 22, 2024 01:04
melnyk1997 pushed a commit to melnyk1997/frontend-academy that referenced this pull request Feb 15, 2025
* Added briefing (long summary) to Grading (source-academy#2310)

* Updated grading briefing to be inline with backend's camelCase

* resolve on some type conflicts

* fix for TypeError on test action

* Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup

* resolved edited export type

Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants