Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add ProtonPlus to the installation methods #1167

Open
Vysp3r opened this issue Sep 16, 2024 · 5 comments
Open

[FEATURE] Add ProtonPlus to the installation methods #1167

Vysp3r opened this issue Sep 16, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Vysp3r
Copy link

Vysp3r commented Sep 16, 2024

I've recently added support for installing/updating/uninstalling STL on ProtonPlus.
It would be nice to see it added in the list of installation methods.
You can test it for yourself to see if the support is good enough for you to add my application to the installation methods.
If you have any questions feel free to ask.

I can create a branch with the modifications myself, but maybe you would rather do it for some reason.

@Vysp3r Vysp3r added the enhancement New feature or request label Sep 16, 2024
@sonic2kk
Copy link
Owner

Thanks for the work on this!

I will add ProtonPlus to the Readme and wiki when I have some time.

@sonic2kk sonic2kk added the documentation Improvements or additions to documentation label Sep 16, 2024
@sonic2kk
Copy link
Owner

I took a look at the current Readme me to see where it would fit in, and the docs very briefly, I think the only thing to bring up is, should there be a dedicated wiki page for usage with ProtonPlus? If so, I am not as familiar with ProtonPlus as I am with ProtonUp-Qt.

If you'd like you can create a Markdown doc and I can copy and paste that into a ProtonPlus wiki page. We have pages under "Platform-Specific Documentation" for ProtonUp-Qt, Steam Deck, and Steam Flatpak.

You can take a look at these pages to get a feel for what you might want to include, for example installation paths (I recall this was a topic of discussion on the ProtonPlus repo) and things like that.

It doesn't have to be super detailed, it can be expanded overtime, ideally GitHub would have better wiki collaboration but right now just copypasting a Markdown doc is probably the most straightforward.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 2, 2024

@Vysp3r Gentle nudge, if you have no preference either way I can just update the Readme and Installation wiki to note that ProtonPlus is an option for installing SteamTinkerLaunch, and link to the project page, without making a dedicated wiki page for it.

@Vysp3r
Copy link
Author

Vysp3r commented Oct 2, 2024

I haven't really worked on ProtonPlus since I created this ticket, I've been busy and got sick recently.
I am also going to be off for two months in 3 days so I don't know if I'll have time to do what you wanted.
I'll try, but if I don't do anything before the 5th you can go ahead and do that.

@sonic2kk
Copy link
Owner

sonic2kk commented Oct 2, 2024

There is no hurry, I will also be quite busy for the next few months I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants