New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any problem with the conditions for deleting sidtable? #2938

Open

kafka-soda opened this issue Oct 18, 2023 · 0 comments

kafka-soda commented Oct 18, 2023

https://github.com/sonic-net/sonic-swss/blob/f31ccd09b8eafa2d9292e7446fc5fe8d4ec0ad06/orchagent/srv6orch.cpp#L363C5-L363C50
I've noticed a potential issue in the code base that I would like to bring to your attention.
"if (sid_table_[sid_name].nexthops.size() > 1)" , I think as long as the sidtable is referenced, it cannot be deleted. So I think condition should be greater than 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment