Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 ACL Missing from SWSS #2934

Open
RaidAndFade opened this issue Oct 17, 2023 · 0 comments
Open

L2 ACL Missing from SWSS #2934

RaidAndFade opened this issue Oct 17, 2023 · 0 comments

Comments

@RaidAndFade
Copy link

Hello, I'm looking at L2 ACL setup on a Mellanox SN2700 running Sonic 202211. I dug through source code, found the following tidbits that led me astray:

https://github.com/sonic-net/sonic-buildimage/blob/202211/src/sonic-yang-models/yang-templates/sonic-acl.yang.j2#L100
This is the ACL yang, Suggesting that "SRC_MAC" and "DST_MAC" exist only if the ACL_TABLE_TYPE is "L2" (which suggests L2 exists)

https://github.com/sonic-net/sonic-buildimage/blob/202211/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L88
The type file suggests that ACL type is enumerated already

https://github.com/Mellanox/SAI-Implementation/blob/a1e395ff9be2a61a38159cf20940201f15dd4201/mlnx_sai/src/mlnx_sai_acl.c#L1560
SAI implementation for mellanox already includes SMAC/DMAC and other L2 related features.

To me (someone who has not touched Sonic source much), it looks like the only missing ingredient here is that the AclTableType doesn't exist during the init at https://github.com/sonic-net/sonic-swss/blob/202305/orchagent/aclorch.cpp#L3206

Obviously i assume this isnt the only thing and im probably missing something, but it feels so close! What's left here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant