You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm looking at L2 ACL setup on a Mellanox SN2700 running Sonic 202211. I dug through source code, found the following tidbits that led me astray:
Hello, I'm looking at L2 ACL setup on a Mellanox SN2700 running Sonic 202211. I dug through source code, found the following tidbits that led me astray:
https://github.com/sonic-net/sonic-buildimage/blob/202211/src/sonic-yang-models/yang-templates/sonic-acl.yang.j2#L100
This is the ACL yang, Suggesting that "SRC_MAC" and "DST_MAC" exist only if the ACL_TABLE_TYPE is "L2" (which suggests L2 exists)
https://github.com/sonic-net/sonic-buildimage/blob/202211/src/sonic-yang-models/yang-templates/sonic-types.yang.j2#L88
The type file suggests that ACL type is enumerated already
https://github.com/Mellanox/SAI-Implementation/blob/a1e395ff9be2a61a38159cf20940201f15dd4201/mlnx_sai/src/mlnx_sai_acl.c#L1560
SAI implementation for mellanox already includes SMAC/DMAC and other L2 related features.
To me (someone who has not touched Sonic source much), it looks like the only missing ingredient here is that the AclTableType doesn't exist during the init at https://github.com/sonic-net/sonic-swss/blob/202305/orchagent/aclorch.cpp#L3206
Obviously i assume this isnt the only thing and im probably missing something, but it feels so close! What's left here?
The text was updated successfully, but these errors were encountered: