update test cases

Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>

Author: Arham-Nasir

tests/hostcfgd/hostcfgd_test.py

@@ -656,18 +656,6 @@ def test_get_memory_statistics_pid_nonexistent(self, mock_pid_exists):
                 self.assertIsNone(pid)
                 mock_syslog.assert_any_call(mock.ANY, "MemoryStatisticsCfg: PID does not exist.")
 
-    # @mock.patch('hostcfgd.psutil.Process')
-    # def test_get_memory_statistics_pid_exception(self, mock_process):
-    #     """Test general exception handling in get_memory_statistics_pid"""
-    #     mock_process.side_effect = Exception("Unexpected error")
-    #     mock_open = mock.mock_open(read_data="123")
-    #     with mock.patch('builtins.open', mock_open):
-    #         with mock.patch('hostcfgd.syslog.syslog') as mock_syslog:
-    #             pid = self.mem_stat_cfg.get_memory_statistics_pid()
-    #             self.assertIsNone(pid)
-    #             mock_syslog.assert_any_call(mock.ANY, 
-    #                 "MemoryStatisticsCfg: Exception failed to retrieve MemoryStatisticsDaemon PID: Unexpected error")
-
     @mock.patch('hostcfgd.psutil.Process')
     def test_get_memory_statistics_pid_exception(self, mock_process):
         """Test general exception handling in get_memory_statistics_pid"""
@@ -706,4 +694,54 @@ def test_wait_for_shutdown_general_exception(self, mock_process):
         with mock.patch('hostcfgd.syslog.syslog') as mock_syslog:
             self.mem_stat_cfg.wait_for_shutdown(123)
             mock_syslog.assert_any_call(mock.ANY, 
-                "MemoryStatisticsCfg: Exception in wait_for_shutdown(): Unexpected shutdown error")
+                "MemoryStatisticsCfg: Exception in wait_for_shutdown(): Unexpected shutdown error")
+            
+    def test_memory_statistics_disable(self):
+        """Test disabling memory statistics"""
+        # First set the initial state to enabled
+        self.mem_stat_cfg.cache['enabled'] = 'true'
+        
+        # Mock the apply_setting method to avoid actual system calls
+        with mock.patch.object(self.mem_stat_cfg, 'apply_setting') as mock_apply:
+            self.mem_stat_cfg.memory_statistics_update('enabled', 'false')
+            
+            # Verify apply_setting was called with correct parameters
+            mock_apply.assert_called_once_with('enabled', 'false')
+            
+            # Verify the cache was updated
+            self.assertEqual(self.mem_stat_cfg.cache['enabled'], 'false')
+
+    def test_memory_statistics_disable_with_shutdown(self):
+        """Test disabling memory statistics with full shutdown chain"""
+        # First set the initial state to enabled
+        self.mem_stat_cfg.cache['enabled'] = 'true'
+        
+        # Mock both get_memory_statistics_pid and os.kill to simulate full shutdown
+        with mock.patch.object(self.mem_stat_cfg, 'get_memory_statistics_pid', return_value=123) as mock_get_pid, \
+             mock.patch('hostcfgd.os.kill') as mock_kill, \
+             mock.patch.object(self.mem_stat_cfg, 'wait_for_shutdown') as mock_wait:
+            
+            self.mem_stat_cfg.memory_statistics_update('enabled', 'false')
+            
+            # Verify the shutdown sequence
+            mock_get_pid.assert_called_once()
+            mock_kill.assert_called_once_with(123, signal.SIGTERM)
+            mock_wait.assert_called_once_with(123)
+            
+            # Verify the cache was updated
+            self.assertEqual(self.mem_stat_cfg.cache['enabled'], 'false')
+
+    def test_memory_statistics_disable_no_running_daemon(self):
+        """Test disabling memory statistics when daemon is not running"""
+        # First set the initial state to enabled
+        self.mem_stat_cfg.cache['enabled'] = 'true'
+        
+        # Mock get_memory_statistics_pid to return None (no running daemon)
+        with mock.patch.object(self.mem_stat_cfg, 'get_memory_statistics_pid', return_value=None) as mock_get_pid:
+            self.mem_stat_cfg.memory_statistics_update('enabled', 'false')
+            
+            # Verify get_pid was called
+            mock_get_pid.assert_called_once()
+            
+            # Verify the cache was updated despite no running daemon
+            self.assertEqual(self.mem_stat_cfg.cache['enabled'], 'false')