Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropcounters | Removing non-existing reason from counter doesn't return an error #13005

Open
Hedgehog-Guru opened this issue Dec 8, 2022 · 0 comments
Labels
Help Wanted 🆘 Issue for 202205 MSFT P1 Priority of the issue, lower than P0

Comments

@Hedgehog-Guru
Copy link

Description

Removing non-existing reason from counter doesn't cause error
qa-eth-vt01-4-3700c:/home/admin# config dropcounter remove-reason COUNTER_1 EXCEEDS_L4_MTU
qa-eth-vt01-4-3700c:/home/admin# echo $?
0

Steps to reproduce the issue:

  1. Add drop counter
  2. Try to remove non-existing reason from existing counter

Describe the results you received:

qa-eth-vt01-4-3700c:/home/admin# config dropcounter remove-reason COUNTER_1 EXCEEDS_L4_MTU
qa-eth-vt01-4-3700c:/home/admin# echo $?
0

Describe the results you expected:

Command should return an Error

Output of show version:

root@qa-eth-vt02-4-3800:/home/admin# show ver

SONiC Software Version: SONiC.202205_1_rc.5-e1553f6d0_Internal
Distribution: Debian 11.5
Kernel: 5.10.0-12-2-amd64
Build commit: e1553f6d0
Build date: Thu Dec  1 16:04:20 UTC 2022
Built by: sw-r2d2-bot@r-build-sonic-ci03-244

Platform: x86_64-mlnx_msn3800-r0
HwSKU: ACS-MSN3800
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1946X20583
Model Number: MSN3800-CS2F
Hardware Revision: A3
Uptime: 19:40:33 up 16:55,  1 user,  load average: 0.28, 0.20, 0.20
Date: Thu 08 Dec 2022 19:40:33

Docker images:
REPOSITORY                                         TAG                                IMAGE ID       SIZE
docker-orchagent                                   202205_1_rc.5-e1553f6d0_Internal   0eed2dee4bbb   479MB
docker-orchagent                                   latest                             0eed2dee4bbb   479MB
docker-fpm-frr                                     202205_1_rc.5-e1553f6d0_Internal   21772aa2895e   490MB
docker-fpm-frr                                     latest                             21772aa2895e   490MB
docker-teamd                                       202205_1_rc.5-e1553f6d0_Internal   407edbcda4de   461MB
docker-teamd                                       latest                             407edbcda4de   461MB
docker-macsec                                      latest                             a6bdcac54c4b   462MB
docker-syncd-mlnx                                  202205_1_rc.5-e1553f6d0_Internal   cc4d5399e43a   863MB
docker-syncd-mlnx                                  latest                             cc4d5399e43a   863MB
docker-platform-monitor                            202205_1_rc.5-e1553f6d0_Internal   0905cbd5b9a9   868MB
docker-platform-monitor                            latest                             0905cbd5b9a9   868MB
docker-snmp                                        202205_1_rc.5-e1553f6d0_Internal   6f0051d3fd3e   488MB
docker-snmp                                        latest                             6f0051d3fd3e   488MB
docker-dhcp-relay                                  latest                             65b23a03b253   453MB
docker-sonic-telemetry                             202205_1_rc.5-e1553f6d0_Internal   b0fbf843d2f3   524MB
docker-sonic-telemetry                             latest                             b0fbf843d2f3   524MB
docker-lldp                                        202205_1_rc.5-e1553f6d0_Internal   4a81664260bf   486MB
docker-lldp                                        latest                             4a81664260bf   486MB
docker-database                                    202205_1_rc.5-e1553f6d0_Internal   c2bbe810f332   444MB
docker-database                                    latest                             c2bbe810f332   444MB
docker-mux                                         202205_1_rc.5-e1553f6d0_Internal   dcb70bef1e87   492MB
docker-mux                                         latest                             dcb70bef1e87   492MB
docker-router-advertiser                           202205_1_rc.5-e1553f6d0_Internal   8feef1cafd6f   444MB
docker-router-advertiser                           latest                             8feef1cafd6f   444MB
docker-sonic-mgmt-framework                        202205_1_rc.5-e1553f6d0_Internal   523493cba2f4   557MB
docker-sonic-mgmt-framework                        latest                             523493cba2f4   557MB
docker-nat                                         202205_1_rc.5-e1553f6d0_Internal   fef615bea196   430MB
docker-nat                                         latest                             fef615bea196   430MB
docker-sflow                                       202205_1_rc.5-e1553f6d0_Internal   3378ad25d8fa   428MB
docker-sflow                                       latest                             3378ad25d8fa   428MB
urm.nvidia.com/sw-nbu-sws-sonic-docker/sonic-wjh   1.3.1-202205-internal-9            7fc7c7f9b751   648MB
urm.nvidia.com/sw-nbu-sws-sonic-docker/doroce      1.0.0-202205-internal-1            a956a3502e02   611MB

Output of show techsupport:

(paste your output here or download and attach the file here )

sonic_dump_qa-eth-vt02-4-3800_20221208_194826.tar.gz

Additional information you deem important (e.g. issue happens only occasionally):

@gechiang gechiang added P1 Priority of the issue, lower than P0 Help Wanted 🆘 labels Jan 4, 2023
@prgeor prgeor added the MSFT label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted 🆘 Issue for 202205 MSFT P1 Priority of the issue, lower than P0
Projects
None yet
Development

No branches or pull requests

4 participants