Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quality of frontend code #7158

Open
16 tasks
jordisala1991 opened this issue May 4, 2021 · 2 comments
Open
16 tasks

Improve quality of frontend code #7158

jordisala1991 opened this issue May 4, 2021 · 2 comments

Comments

@jordisala1991
Copy link
Member

Feature Request

We have been following a process to integrate our frontend code with webpack encore. However, that process didn't include the refactoring of that code.

Here are some things that came to my mind while doing that process:

  • Split css files into smaller components
  • Reduce specifity of css selectors
  • Split js into smaller components
  • Remove usages of jQuery as much as possible

And of course we didn't intergate the inline javascript: (not sure if we should open another issue for that, for now I will just leave it like this)

I don't know if we code is prepared as it is to be documented on how to customize it. My opinion is that some moves needs to be made BEFORE actually documenting how to customize it:

  • Documentation about the frontend assets for users of the bundle
@jordisala1991
Copy link
Member Author

2 Examples on how to do it on small steps: #7152 #7145

@jordisala1991
Copy link
Member Author

This PR introduces first frontend only tests of Sonata: sonata-project/form-extensions#427

Using Stimulus to rewrite code and Vite + Testing Library to test the controller.

This is the foundation of future Sonata Admin javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant