Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "AND" for JWT validation #7254

Open
asayah opened this issue Sep 27, 2022 · 2 comments
Open

Support "AND" for JWT validation #7254

asayah opened this issue Sep 27, 2022 · 2 comments
Assignees
Labels
Area: Auth Area: Envoy activities related to envoy proxy stale Issues that are stale. These will not be prioritized without further engagement on the issue. Triage: Needs Information Type: Enhancement New feature or request

Comments

@asayah
Copy link
Contributor

asayah commented Sep 27, 2022

Version

No response

Is your feature request related to a problem? Please describe.

whether we could make a specific route AND providers together instead of the current behavior which is OR. In other words, certain routes requiring jwt pass validation on both providers if two providers are listed.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional Context

No response

@asayah asayah added the Type: Enhancement New feature or request label Sep 27, 2022
@sam-heilbron
Copy link
Contributor

The JWT filter supports both requires_any and requires_all: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/jwt_authn/v3/config.proto#extensions-filters-http-jwt-authn-v3-jwtauthentication

The Edge API currently only configures the requires_any portion of the filter, which behaves as an OR.

@asayah am I correct in understanding that adding support for requires_all will resolve this ask? Also, depending on the complexity of the changes, is the 1.13 beta a reasonable target for this work, or is the feature needed on a particular branch?

Copy link

github-actions bot commented Jun 6, 2024

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

@github-actions github-actions bot added the stale Issues that are stale. These will not be prioritized without further engagement on the issue. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Auth Area: Envoy activities related to envoy proxy stale Issues that are stale. These will not be prioritized without further engagement on the issue. Triage: Needs Information Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants