Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for enabling TCP keepalive for downstream connection #10089

Open
andy-fong opened this issue Sep 23, 2024 · 0 comments
Open

Improve UX for enabling TCP keepalive for downstream connection #10089

andy-fong opened this issue Sep 23, 2024 · 0 comments
Labels
Type: Enhancement New feature or request

Comments

@andy-fong
Copy link
Contributor

andy-fong commented Sep 23, 2024

Gloo Edge Product

Open Source

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

envoy only supports enabling TCP keepalive on downstream connection through the generic socket_options on the Listener config. On upstream clusters, it has the tcpkeepalive structure but not for downstream.

gloo currently expose the socket_options setting to enable TCP keepalive (see example here. Having to set 4 socket options is tedious and can be error prone.

We can expose the TCP keepalive object for downstream and translate to the socket options envoy needs for better UX.

Describe the solution you'd like

In Gloo Mesh Enterprise, we have an implementation that exposes a ListenerConnectionPolicy resource that can be applied to the listner to setup TCP keepalive. See example here. We can have similar implementation to improve UX.

Describe alternatives you've considered

No response

Additional Context

No response

@andy-fong andy-fong added the Type: Enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant