Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Stripe Payment Intents to Spree::Payment #154

Closed
2 tasks done
Tracked by #142
elia opened this issue Dec 21, 2022 · 0 comments · Fixed by #158
Closed
2 tasks done
Tracked by #142

Link Stripe Payment Intents to Spree::Payment #154

elia opened this issue Dec 21, 2022 · 0 comments · Fixed by #158
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@elia
Copy link
Member

elia commented Dec 21, 2022

What

We need to map each Spree::Payment to a single Payment Intent, and thus have a single Stripe Spree::Payment for a given order that will track all the payment attempts made for the Payment Intent. Stripe recommends having a single payment intent per order.

Tasks

Preview Give feedback

Dependencies

Mapping between Solidus and Stripe payment states

The following is the tentative mapping between the states in the two systems, since in Stripe the "failed" state is just going back to the starting point we'll treat anything before a final state as :processing.

image

Why

Since Stripe considers updates sent via webhooks to be the most reliable source of truth, we need a place in which to track the history of each payment tracking attempts, failures, refusals, successes etc.

The entity that can best take up this role seems to be Spree::Payment.

@elia elia mentioned this issue Dec 21, 2022
11 tasks
@elia elia changed the title Ensure each Stripe::PaymentIntent is linked to a Spree::Payment Link Stripe Payment Intents to Spree::Payment Feb 9, 2023
@elia elia added the enhancement New feature or request label Feb 9, 2023
@elia elia added this to the v5 milestone Feb 22, 2023
@elia elia closed this as completed in #158 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant