Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the locale doesn't change the Cart label #131

Open
ChristianRimondi opened this issue Nov 13, 2020 · 1 comment
Open

Changing the locale doesn't change the Cart label #131

ChristianRimondi opened this issue Nov 13, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ChristianRimondi
Copy link
Contributor

There is a cache issue when changing the locale using the locale selector. The Cart label doesn't change until the cart is updated (i.e. adding o removing an item):
Schermata 2020-11-13 alle 16 17 09
I think that the problem could be here, the fresh_when method doesn't take into account the locale but only the current_order.

Hint for a possible solution https://stackoverflow.com/a/37026009

@ChristianRimondi ChristianRimondi added the bug Something isn't working label Nov 13, 2020
@ChristianRimondi ChristianRimondi added this to the v1.0.0 milestone Nov 13, 2020
@ChristianRimondi ChristianRimondi self-assigned this Nov 27, 2020
@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2022
@gsmendoza gsmendoza removed the stale label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants