Google Analytics 4 GA4

[seandawes]

Google Analytics is becoming end of life and Google will be moving everyone to GA4. Stores are or will be needing to migrate very soon to GA4 and will lose all historical data from their analytics account potentially within a year.

I would deem this as a priority for the platform

Additional Info
https://developers.google.com/analytics/devguides/collection/ga4/ecommerce?client_type=gtag

Currently Solidus docs outline old GA support
https://guides.solidus.io/developers/integrations/google-analytics

[fthobe]

Hey @jarednorman ,

Is this core or custom?

It has implications also for https://github.com/solidusio-contrib/solidus_multi_domain as variables should be stored there.

[fthobe]

I'm not sure what you mean "field brand that picks from existing taxonomies".

A simple field similar to the current one for taxons with one allowed value instead of many.

[fthobe]

I'm not sure what you mean "field brand that picks from existing taxonomies".

My suggestion would be to add a Spree::Product#brand method that looks up what taxon the product is in with in a "Brand" taxonomy, if one exists. Something like that.

I struggle with taxon#brand as it opens doors to varying results and multiple brands (I also find replicating the current taxon creator with a limitation to one item more charming for the obvious reason that it creates much less work.

[kennyadsl]

I don't think @jarednorman is suggesting to have multiple brands, but connect the brand to one category/taxon.
My suggestion here is to make it easily configurable, so anyone can easily replace their own logic easily. In Pseudo-Code it is something like:

# app/models/spree/product.rb

class Spree::Product
  def brand
    Spree::Config.brand_selector_class.new(product).call
  end
end

# app/models/spree/taxon_brand_selector.rb

class Spree::TaxonBrandSelector
  attr_reader :product

  def initialize(product)
    @product = product
  end

  def call
    product.taxons.joins(:taxonomy).where(spree_taxonomies: { name: "Brands" }).first
  end
end

# app/models/app_configuration.rb

class_name_attribute :brand_selector_class, default: 'Spree::TaxonBrandSelector'

This way, we have a simple, default primitive in core and anyone can easily extend this by configuring their own class:

Spree::Config.brand_selector_class = MySuperComplexBrandSelector

Sounds good?

[fthobe]

Works for me

[jarednorman]

Indeed that is what I meant.