Skip to content

Commit 9eeec33

Browse files
committed
Exclude new mostly inappropriate slither detectors
1 parent e4237c4 commit 9eeec33

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

contracts/colony/ColonyFunding.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ contract ColonyFunding is ColonyStorage { // ignore-swc-123
475475
}
476476
}
477477

478+
// slither-disable-next-line reentrancy-unlimited-gas
478479
emit PayoutClaimed(msgSender(), _fundingPotId, _token, remainder);
479480
}
480481

contracts/extensions/CoinMachine.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ contract CoinMachine is ColonyExtension, BasicMetaTransaction {
250250

251251
require(ERC20(token).transfer(msgSender(), numTokens), "coin-machine-transfer-failed");
252252

253+
// slither-disable-next-line reentrancy-unlimited-gas
253254
emit TokensBought(msgSender(), token, numTokens, totalCost);
254255
}
255256

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"test:contracts:watch": "npm run start:blockchain:client & truffle migrate --reset --compile-all && truffle watch --network development",
4444
"test:contracts:e2e": "npm run start:blockchain:client & truffle migrate --reset --compile-all && truffle test test-system/end-to-end.js --network development",
4545
"test:contracts:smoke": "truffle compile && truffle test ./test-smoke/colony-storage-consistent.js --network storageSmoke",
46-
"test:security:slither": "slither . --solc-disable-warnings --exclude-low --exclude-informational --exclude-optimization --exclude uninitialized-state-variables,uninitialized-local-variables --filter-paths 'lib|contracts/testHelpers'",
46+
"test:security:slither": "slither . --solc-disable-warnings --exclude-low --exclude-informational --exclude-optimization --filter-paths 'lib|contracts/testHelpers'",
4747
"test:security:mythril": "truffle run verify --mode quick --style json --limit 1 --swc-blacklist 101,123,128,131 > truffle-security-output.json; sed -i '/^\\[{/!d' ./truffle-security-output.json && node ./scripts/process-truffle-security.js",
4848
"pretest:contracts": "sed -ie \"s/eth-gas-reporter/mocha-circleci-reporter/g\" ./truffle.js && rimraf ./truffle.jse",
4949
"pretest:contracts:upgrade:parity": "sed -ie \"s/eth-gas-reporter/mocha-circleci-reporter/g\" ./truffle.js && rimraf ./truffle.jse",

slither.config.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"detectors_to_exclude": "unused-state,naming-convention,solc-version,external-function,pragma,constable-states",
2+
"detectors_to_exclude": "unused-state,naming-convention,solc-version,external-function,pragma,constable-states,missing-inheritance,unintialized-state,assembly,boolean-equal,costly-loop,low-level-calls,missing-inheritance,similar-names,too-many-digits,uninitialized-state-variables,uninitialized-local-variables",
33
"solc_args": "--allow-paths .",
44
"solc_disable_warnings": true
5-
}
5+
}

0 commit comments

Comments
 (0)