Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[dev]: ✨ implement A11y improvements to sd-header #1478

Open
2 of 10 tasks
Tracked by #1465
yoezlem opened this issue Oct 9, 2024 · 0 comments
Open
2 of 10 tasks
Tracked by #1465

feat[dev]: ✨ implement A11y improvements to sd-header #1478

yoezlem opened this issue Oct 9, 2024 · 0 comments
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Critical A11y Issue Require immediate attention and resolution Subtask Epic subtasks

Comments

@yoezlem
Copy link
Contributor

yoezlem commented Oct 9, 2024

Description

This task describes the Storybook implementation for the sd-header component as part of the A11y improvements outlined in Epic #1465.

A11y improvements for sd-checkbox can be found here: sd-header Notes.


Comment

Problem: Icon-only buttons have no accessible name (burger, Weitere Auftritte, search).
Solution: Add one.

Problem: The menu button (burger icon) doesn't do anything.
Solution: It must toggle the list's visibility.

Problem: The menu button misses essential information: it has no accessible name and doesn't indicate whether the navigation is visible.
Solution: Add an accessible name, put aria-expanded on it and toggle its value.

Problem: The fixed header covers much of the screen when the viewport's zoomed in.
Solution: Consider making headers only fixed at a certain minimum viewport height.

  • figure out why its not working in codepen (timeslot is 30min, after that we should create a Ticket for that issue)

Problem: The description of the logo serves as the accessible name of the link in which it's wrapped.
Solution: Thus, it must not describe the image ("Logo"), but the links function "Union Investment Homepage.”

Related WCAG criteria

Additional resources

Open Questions

  • Question1
  • Question2

DoR

  • Item has been estimated by the team
  • Item dependencies have been identified and documented

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@yoezlem yoezlem added 🔧 code needs changes in code Subtask Epic subtasks labels Oct 9, 2024
@yoezlem yoezlem added A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS Critical A11y Issue Require immediate attention and resolution labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Critical A11y Issue Require immediate attention and resolution Subtask Epic subtasks
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant