Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[dev]: ✨ brandshape image without default slot #1339

Open
9 tasks
Tracked by #1375
smfonseca opened this issue Sep 2, 2024 · 0 comments
Open
9 tasks
Tracked by #1375

feat[dev]: ✨ brandshape image without default slot #1339

smfonseca opened this issue Sep 2, 2024 · 0 comments
Assignees
Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code

Comments

@smfonseca
Copy link
Contributor

User Story

As a user of the Solid Design System, I want to display images with the brandshape and there should be no option to include content on top of the image.

Suggested Solution

If the chosen variant is image, the default slot should not be rendered.

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@smfonseca smfonseca added the 🔧 code needs changes in code label Sep 2, 2024
@yoezlem yoezlem added the BREAKING CHANGE all issues which end up in a breaking change label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants