Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obligation_owner should be readonly #87

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Obligation_owner should be readonly #87

merged 1 commit into from
Sep 16, 2022

Conversation

andrewsource147
Copy link

Issue: As in description WithdrawObligationCollateralAndRedeemReserveCollateral combines WithdrawObligationCollateral and RedeemReserveCollateral. While obligation_owner in WithdrawObligationCollateral is readonly, it is writable in WithdrawObligationCollateralAndRedeemReserveCollateral.

Solution: Update obligation_owner readonly in WithdrawObligationCollateralAndRedeemReserveCollateral

@andrewsource147
Obligation_owner should be readonly
d36f91e 
Issue: As in description `WithdrawObligationCollateralAndRedeemReserveCollateral` combines `WithdrawObligationCollateral` and `RedeemReserveCollateral`. While `obligation_owner` in `WithdrawObligationCollateral` is readonly, it is writable in `WithdrawObligationCollateralAndRedeemReserveCollateral` is writable. 

Solution: Update `obligation_owner` readonly in `WithdrawObligationCollateralAndRedeemReserveCollateral`
@nope-finance
Copy link
Member

thanks will add this in soon

@nope-finance nope-finance changed the base branch from mainnet to upcoming June 5, 2022 12:24
@nope-finance nope-finance merged commit 075972c into solendprotocol:upcoming Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsource147 @nope-finance